chore: remove unused pkg/descriptors and deprecated FromTarget#52
Merged
Conversation
The pkg/descriptors package has no remaining callers — the plugin SDK derives resource schemas from schema/pkl at startup. FromTarget was superseded by FromTargetConfig and is no longer referenced. Dropping these also removes apple/pkl-go as a direct dependency (now indirect via the plugin SDK).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvages the dead-code removal from the stale #20 against current main.
pkg/descriptors/— nothing imports it; the plugin SDK reads resource schemas fromschema/pkl/at startup.FromTargetfrompkg/config/config.go(superseded byFromTargetConfig).apple/pkl-godrops from direct to indirect dep as a side-effect.Test plan