feat: populate LabelConfig with resource-specific label queries#53
Merged
Conversation
Most OCI resources expose a human-readable name via DisplayName — set that as the default. Compartment, Policy, Cluster, NodePool, and Bucket use Name instead, so override those. Without this, discovered resources fall back to their OCID as the label, which is opaque.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvages the LabelConfig piece from the stale #20, ported to
model.LabelConfig(main moved these types frompkg/plugin→pkg/modelafter #20 was opened).\$.DisplayName(works for VCN, Subnet, Volume, VirtualNodePool, …)\$.Namefor Compartment, Policy, Cluster, NodePool, Bucket — these resources expose a `Name` property instead of `DisplayName`.Without this, discovered resources fall back to their OCID as the label.
Test plan