schema: RFC-0043 edgeKind=attachesTo on subnet/VNIC/OKE network attachments#67
Open
JeroenSoeters wants to merge 2 commits into
Open
schema: RFC-0043 edgeKind=attachesTo on subnet/VNIC/OKE network attachments#67JeroenSoeters wants to merge 2 commits into
JeroenSoeters wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Annotates 8 fields with
edgeKind = "attachesTo"per RFC-0043 (typed DAG edges):Subnet.routeTableId,Subnet.securityListIds(without these, destroying the route table or security lists before the subnet strands traffic at runtime).Instance.createVnicDetails.nsgIds, plus OKE Cluster / NodePool / VirtualNodePool NSG references. NSGs gate runtime reachability and should outlive the resources using them.RouteRule.networkEntityId(IGW/NGW/SGW/LPG). Routes pointing at a gateway need the gateway to exist for traffic to flow.These are reachability edges — consumers are "reachable through" producers at runtime. Without the annotation, the engine's default destroy order would tear down the producer before the consumer, breaking the runtime semantics.
Depends on
formae#484 — engine work that introduces
EdgeKind. Must merge in lockstep.Validation
Mechanical schema-only annotations; the engine's
attachesTobehavior was already validated end-to-end against real AWS in the engine PR's companion debug-conformance run. Localpkl evalconfirms schemas parse cleanly against the newformae@0.86.0types.Notes
formae@0.86.0pin tracks the snapshot from RFC-0043's engine branch; will track the real release when it ships.runtimeDependencycandidates exist in current schema. FSS FileSystem+MountTarget (the OCI analog to EFS) would be a textbookruntimeDependencycase if/when those resource types are added.Subnet.vcnId,*.compartmentId, etc.) deliberately NOT annotated — they're already handled correctly by default edges viaSchema.Parent.RFC: https://github.com/platform-engineering-labs/rfcs/blob/rfc-0043-typed-dag-edges/rfc-0043-typed-dag-edges.md