vitBackButton#42
Open
V1taliy wants to merge 9 commits into
Open
Conversation
YuriiHoliuk
reviewed
Dec 3, 2017
| @@ -1,3 +1,6 @@ | |||
| <div class="modal"> | |||
| the very best modal | |||
Contributor
There was a problem hiding this comment.
But where is place to paste modal content?
Contributor
Author
There was a problem hiding this comment.
we do not specified how it should be, I add few tag's
YuriiHoliuk
reviewed
Dec 3, 2017
| <div class="modal"> | ||
| the very best modal | ||
| <div class="modal-body"> | ||
| <button (click)="closeModal('modal');">X</button> |
Contributor
There was a problem hiding this comment.
Why do you pass 'modal' instead of $event?
tatsiak
suggested changes
Dec 13, 2017
tatsiak
left a comment
tatsiak
left a comment
Contributor
There was a problem hiding this comment.
Не нужно отключать тесты для команды ci.
Я вернул запуск e2e тестов и сейчас на тревисе проверки падают.
Необходимо разобраться и исправить.
| "lint": "ng lint", | ||
| "e2e": "ng e2e", | ||
| "ci": "npm run lint && npm run test:once && npm run e2e", | ||
| "ci": "npm run lint", |
Contributor
There was a problem hiding this comment.
Для чего отключать тесты здесть?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add back button and modify custom modal window