Options for test#45
Open
dzudzylo wants to merge 4 commits into
Open
Conversation
YuriiHoliuk
reviewed
Dec 3, 2017
| writeValue(value: Question) { | ||
| if (value !== void(0)) { | ||
| this.form.setValue(value); | ||
| this.form.patchValue(value); |
Contributor
There was a problem hiding this comment.
Why did you rename answers to options? On back-end we have answers and if you pass value(from back-end) to this form form, you will recieve error or unexpected behavior, because form except answers field
YuriiHoliuk
reviewed
Dec 3, 2017
YuriiHoliuk
left a comment
YuriiHoliuk
left a comment
Contributor
There was a problem hiding this comment.
Все супер крім коменту який я написав.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
options for the test item added