feat: migrate to new golang-commons config API (#81)#84
Merged
Conversation
Contributor
makdeniss
commented
Mar 5, 2026
makdeniss
commented
- Migrate to the new golang-commons config API.
- Replace legacy Viper-based config binding (NewDefaultConfig(rootCmd) + BindConfigToFlags) with explicit constructor/flags wiring.
- Keep existing CLI defaults and flag names to preserve current behavior.
makdeniss
requested review from
OlegErshov,
aaronschweig,
akafazov and
simontesar
aaronschweig
reviewed
Mar 5, 2026
Contributor
There was a problem hiding this comment.
I am not the biggest fan of having these config tests. They test flag parsing behavior is testing golang internals
Contributor
Author
There was a problem hiding this comment.
I tried to follow the existing approaches. And I've also seen that Bastian added them if they were missing: https://github.com/platform-mesh/extension-manager-operator/pull/635/changes
aaronschweig
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.