Skip to content

Warn when --sort-by is used that results may not be globally sorted #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidnortonjr merged 1 commit into from
Mar 29, 2026
Merged

Warn when --sort-by is used that results may not be globally sorted #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmd/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,20 @@ func (p *progressBar) finish() {
<-p.done
}

func hasSortBy(args []string) bool {
for _, arg := range args {
if arg == "--sort-by" || strings.HasPrefix(arg, "--sort-by=") {
return true
}
}
return false
}

func runCommand(subcommand string, extraArgs []string) error {
if hasSortBy(extraArgs) {
fmt.Fprintf(os.Stderr, "Warning: --sort-by sorts within each context independently and may not produce the expected global ordering. See https://github.com/platformersdev/kubectl-x/issues/29\n")
}

contexts, err := getContexts()
if err != nil {
return fmt.Errorf("failed to get contexts: %w", err)
Expand Down
Loading