Fix dropdown clipping in filter and segment modals#6489
Open
sanne-san wants to merge 1 commit into
Open
Conversation
- Add `grow` mode to `Modal` that lets the panel grow with content and defers scroll to the outer overlay - `ModalLayout` opts in, so filter and segment modals stop clipping combobox popovers - Breakdown modals keep the bounded behavior as inner content scrolls - Remove dead `viewport`/`handleResize`/`DEFAULT_WIDTH`/`getStyle`/`allowScroll` plumbing
|
aerosol
approved these changes
Jul 7, 2026
|
apata
requested changes
Jul 7, 2026
apata
left a comment
apata
left a comment
Contributor
There was a problem hiding this comment.
Unfortunately, this introduces a new clipping issue in breakdown modals when using a phone in landscape mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
growmode toModalthat lets the panel grow with content and defers scroll to the outer overlayModalLayoutopts in, so filter and segment modals stop clipping combobox popoversviewport/handleResize/DEFAULT_WIDTH/getStyle/allowScrollplumbingTests
Changelog
Documentation
Dark mode