Preserve partial canonical PLY layers for 2DGS compatibility - #284
Draft
Arison591 wants to merge 1 commit into
Draft
Preserve partial canonical PLY layers for 2DGS compatibility#284Arison591 wants to merge 1 commit into
Arison591 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
otherextras instead of silently dropping themscale_2DataTablecompatibility bridgeRoot cause
The 3.0
ChunkSourcemigration only creates the geometric layer when all eight geometric properties are present. At the same time, its extras filter excluded every standard property name unconditionally. Official 2DGS PLY files omitscale_2, sorot_*,scale_0,scale_1, andopacitywere discarded before SuperSplat could materialize the table and run its existingscale_2compatibility shim.This change only treats names as canonical when their complete layer is available. Partial-layer properties remain lossless extras, preserving the source semantics without claiming native 2DGS/SOG encoding support.
Related to #166 and unblocks playcanvas/supersplat#975.
Validation
npm run lintnpm run buildnpm run publint(passes with the repository's existingsideEffectssuggestion)render-golden.test.mjs; the three golden-render cases require Vulkan, which is unavailable in this environment