roots calculated by looking at the export file rather than import path#345
Merged
goddenrich merged 1 commit intoplease-build:masterfrom Apr 2, 2026
Merged
Conversation
toastwaffle
approved these changes
Apr 2, 2026
goddenrich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were using the package import path and comparing it with the directories of files discovered but there might be some reason why this would not correspond with the directory the package lives in. The export file does live in the same directory as the package so use that file's directory instead. Also strip absolute paths from the files before adding the directory since the package info json doesn't have absoulte paths.