Add bulk actions for rename, workflow, tags, and properties management#110
Add bulk actions for rename, workflow, tags, and properties management#110nils-pzr wants to merge 7 commits into
Conversation
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
This is amazing documentation! Thank you! Thank you! Thank you!
I made a few suggestions, some of which need your verification. Would you please take care? Thank you, again!
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
Thanks for making the changes. I have a couple more changes, and let's get that folder icon inline.
|
Side note, I see that the readme linkcheck is failing for the renamed demo site, but I assume we can ignore that for now, as it will eventually be live. Can someone at the sprint confirm? |
@stevepiercy yes, @fredvd is working on it at the sprint |
…, and enhance localization files.
pnicolli
left a comment
pnicolli
left a comment
There was a problem hiding this comment.
Overall very good, thanks! Just a couple notes.
|
|
||
| const workflowPath = `${validatedArgs.path}/@workflow/publish`; | ||
| const workflowPath = `${validatedArgs.path}/@workflow/${ | ||
| validatedArgs.transition ?? 'publish' |
There was a problem hiding this comment.
I would not make this optional in the schema and would not have a fallback here. Thoughts @sneridagh ?
There was a problem hiding this comment.
@pnicolli certainly not optional, and clearly an overlook from the original implementation. However, now I am confused. It's createXXX because it's POST? We are not creating a workflow, right? meh... we should review some of the names, although now I remember that the policy was to match the plone.restapi naming schema so one can relate to what endpoint makes reference.
No fallback either, it has no sense (again from the original implementation).
There was a problem hiding this comment.
Yeah then let's remove the optional and the fallback and make the transition parameter mandatory, and let's discuss possible renaming later.
| icon: <PropertiesIcon />, | ||
| }; | ||
| showToast(toast); | ||
| revalidate(); |
There was a problem hiding this comment.
Is this needed? I see I did not need to manually revalidate in the UploadModal. Revalidating can usually be triggered by the backend action the fetcher is submitting to
| icon: <RenameIcon />, | ||
| }; | ||
| showToast(toast); | ||
| revalidate(); |
There was a problem hiding this comment.
Same question as above, marking this as well so we miss instances
| icon: <TagIcon />, | ||
| }; | ||
| showToast(toast); | ||
| revalidate(); |
There was a problem hiding this comment.
Same question as above, marking this as well so we miss instances
| icon: <StateIcon />, | ||
| }; | ||
| showToast(toast); | ||
| revalidate(); |
There was a problem hiding this comment.
Same question as above, marking this as well so we miss instances
5 participants
closes #108
📚 Documentation preview 📚: https://plone-aurora--110.org.readthedocs.build/