Skip to content

71 search results#116

Open
nils-pzr wants to merge 5 commits into
mainfrom
71-search-results
Open

71 search results#116
nils-pzr wants to merge 5 commits into
mainfrom
71-search-results

Conversation

@nils-pzr

@nils-pzr nils-pzr commented Jun 10, 2026

Copy link
Copy Markdown

📚 Documentation preview 📚: https://plone-aurora--116.org.readthedocs.build/

@nils-pzr nils-pzr linked an issue Jun 10, 2026 that may be closed by this pull request
@nils-pzr nils-pzr requested review from pnicolli and stevepiercy June 10, 2026 12:51

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started an editorial review, but aborted my effort after I realized that this is not a how-to guide. Its content is more of an explanation and feels better placed in the conceptual guides.

If there is how-to material, then it should be in a separate page, focusing on how to perform tasks, not explain how things work.

Please take a look at the Diátaxis framework https://diataxis.fr/ for a thorough explanation of four quadrants of technical documentation. Feel free to hit me up in Discord for discussion.

Comment thread docs/how-to-guides/search-the-site.md Outdated
Comment thread packages/layout/news/+search-facets.feature Outdated
Comment thread docs/how-to-guides/search-the-site.md Outdated
Comment thread docs/how-to-guides/search-the-site.md Outdated
Comment thread docs/how-to-guides/search-the-site.md Outdated
Comment thread docs/how-to-guides/search-the-site.md Outdated
@nils-pzr nils-pzr linked an issue Jun 12, 2026 that may be closed by this pull request
@nils-pzr

Copy link
Copy Markdown
Author

Thanks for the review, @stevepiercy - you were right, it was an explanation wearing a how-to hat.

Changes since your review:

  • Split per Diátaxis: conceptual-guides/search.md (how it works) and how-to-guides/customize-the-search.md (tasks only); the old page is gone.
  • Applied all your inline suggestions, including the newsfragment wording and the {file} role.
  • Verified the accessibility claims in the browser before adopting your wording - that surfaced a missing keyboard focus indicator on the result links, now fixed (plus pagination links).
  • All code excerpts in the docs are now verbatim from the source files.

@nils-pzr nils-pzr requested a review from stevepiercy June 12, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Aurora Views] - Search route [Aurora Slots] - Header

3 participants