71 search results#116
Open
nils-pzr wants to merge 5 commits into
Open
Conversation
… localized result count
…support sorting, pagination, and tag filtering
stevepiercy
requested changes
Jun 10, 2026
stevepiercy
left a comment
Contributor
There was a problem hiding this comment.
I started an editorial review, but aborted my effort after I realized that this is not a how-to guide. Its content is more of an explanation and feels better placed in the conceptual guides.
If there is how-to material, then it should be in a separate page, focusing on how to perform tasks, not explain how things work.
Please take a look at the Diátaxis framework https://diataxis.fr/ for a thorough explanation of four quadrants of technical documentation. Feel free to hit me up in Discord for discussion.
…umentation and styles
…, and improved localization
Author
|
Thanks for the review, @stevepiercy - you were right, it was an explanation wearing a how-to hat. Changes since your review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://plone-aurora--116.org.readthedocs.build/