Skip to content

#47 Add @@personal-information to CMSUI#117

Open
szakitibi wants to merge 15 commits into
mainfrom
47-user_preferences_route
Open

#47 Add @@personal-information to CMSUI#117
szakitibi wants to merge 15 commits into
mainfrom
47-user_preferences_route

Conversation

@szakitibi

@szakitibi szakitibi commented Jun 10, 2026

Copy link
Copy Markdown

What this does

Adds @@persona-information route to CMSUI, with the form for all the fields correctly read from @userschema.

See also discussion on #47.

A couple of notes for reviewers

See below the rough edges #117 (comment).

Contributors

@szakitibi

szakitibi commented Jun 12, 2026

Copy link
Copy Markdown
Author

@pnicolli

First implementation of the @@personal-information is done. Updated branch with current main to resolve conflicts. README.md check failure is unrelated as far as I see.

Rough edges, which were not blockers, just flagging them:

  • I've added "personal information" to the dev header next to login/logout. I've also parked the idea using the left toolbar with Plug, since it should go under some sort of user settings menu eventually.
  • Currently Save/Cancel live inside the form because the toolbar Plug button's onPress/onSubmit never fired.
  • The form is rendered schema based. However there is no email/url widgets registered, so for now everything renders as plain TextField.
  • The portrait field is also renders as a text box, thus it is skipped on "Save".
  • Change-Password link has been created with reset-password route from PR #48 Add password reset flow to CMS UI #109. I have not bumped into any change-password route, so put it there as a reminder - see also [CMSUI] - User preferences route #47 (comment).
  • Entry point is the header, the real home is a future user/avatar menu. I assume it will have its own issue.
  • The language/timezone fields are out of scope. See discussion about the issues with @userschema and write-only backend - see also [CMSUI] - User preferences route #47 (comment). That is until plone.restapi provides an updated schema with IPersonalPreferences fields and read path for the same fields - TBD.
  • I was unable to confirm translations. I tried extending supportedLanguages, which is hardcoded to ['en'], but had no effect. Probably I'm missing something.
  • For accepntance tests I have used the plone.app.testing's user test_user_1_. I've seeded it with data for the tests. That might be something to move into the tooling/playwright, to make it reusable.
  • Minimal a11y and alerts, since no central Form feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant