Conversation
|
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
To be kept within the manual section, so a new run of `config-package` will not delete it.
gforcada
force-pushed
the
convert-setup-py-to-pyproject-toml
branch
from
ed2c297 to
ccaa77e
Compare
mauritsvanrees
left a comment
mauritsvanrees
left a comment
There was a problem hiding this comment.
This is mostly fine, but I added some suggestions.
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", |
There was a problem hiding this comment.
Since we are editing this, let's update the classifiers:
| "Programming Language :: Python :: 3.10", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.10", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", | |
| "Programming Language :: Python :: 3.13", | |
| "Programming Language :: Python :: 3.14", |
| {name = "Plone Foundation",email = "plone-developers@lists.sourceforge.net"}, | ||
| ] | ||
| maintainers = [ | ||
| {name = "Plone Foundation and contributors",email = "zope-dev@zope.dev"}, |
There was a problem hiding this comment.
I am not sure where the zope.dev email came from.
| {name = "Plone Foundation and contributors",email = "zope-dev@zope.dev"}, | |
| {name = "Plone Foundation and contributors",email = "plone-developers@lists.sourceforge.net"}, |
| Changelog = "https://github.com/plone/plone.batching/blob/master/CHANGES.rst" | ||
|
|
||
| [tool.setuptools.dynamic] | ||
| readme = {file = ["README.rst", "CHANGES.rst"]} |
There was a problem hiding this comment.
We included docs/usage.rst until now. Would be good to keep that.
This worked for me, but it may fail on Windows:
readme = {file = ["README.rst", "CHANGES.rst", "docs/usage.rst"]}
We could just copy the contents of docs/usage.rst to the readme, and remove the rest of the docs dir, as it seems unused.
3 participants
Uh oh!
There was an error while loading. Please reload this page.