Skip to content

Shifting from .md to html in Nuclia - #881

Open
justdaksh wants to merge 8 commits into
plone:nuclia_widgetfrom
justdaksh:nuclia_widget
Open

Shifting from .md to html in Nuclia#881
justdaksh wants to merge 8 commits into
plone:nuclia_widgetfrom
justdaksh:nuclia_widget

Conversation

@justdaksh

@justdaksh justdaksh commented Nov 20, 2024

Copy link
Copy Markdown

@stevepiercy Nuclia Knowledge Base has now been indexed with HTML

Issues

  • Some result's URL appear to be broken
  • Bug in CI workflow
  • Breadcrumbs not visible in search results

📚 Documentation preview 📚: https://plone-training--881.org.readthedocs.build/

@justdaksh justdaksh changed the title Shifting from .md to html injestion Shifting from .md to html in Nuclia Nov 20, 2024

@stevepiercy stevepiercy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions. Otherwise this looks good.

Comment thread .github/workflows/nuclia_sync.yml Outdated
Comment thread upload.py
@justdaksh

Copy link
Copy Markdown
Author

Ahh yes, transform_path_to_url function just merges normalize and create URL. I forgot to remove them but I have fixed that now.
when creating URL for volto_customization training we need - instead of _ so the function just does that only.
so we get https://training.plone.org/volto-customization/index.html
instead of https://training.plone.org/volto_customization/index.html

@stevepiercy

Copy link
Copy Markdown
Member

Yes, but why do we get volto_customization/index.html in the first place? I refactored that to use - a few days ago.

@justdaksh

justdaksh commented Nov 22, 2024

Copy link
Copy Markdown
Author

I guess the fix might not have been synced withnuclia_widget branch

@stevepiercy

Copy link
Copy Markdown
Member

Ah, yes, that would do it. Let me do that now, and we can take another look.

Also, one training will be added soon (I hope) and another will go away, so that synch will need to happen again.

@stevepiercy

Copy link
Copy Markdown
Member

@justdaksh done! Pull and let's have a look together.

@justdaksh

Copy link
Copy Markdown
Author

yay! URLs don't break anymore.

@stevepiercy

Copy link
Copy Markdown
Member

We still have CI failure, but let's handle that in the base branch PR in #792 (comment)

@stevepiercy

Copy link
Copy Markdown
Member

CI passed in base PR, updated base branch here and resolved conflicts. We'll see if that resolves the CI issue.

@stevepiercy

Copy link
Copy Markdown
Member

CI passes. That leaves the breadcrumb issue.

Also I updated the RTD PR preview URL slug, so it is now at: https://plone-training--881.org.readthedocs.build/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants