Skip to content

feat: add enable_extensions option to control browser extension loading#303

Merged
camdecoster merged 4 commits into
plotly:mainfrom
hirohira9119:disable_extensions
Jul 22, 2026
Merged

feat: add enable_extensions option to control browser extension loading#303
camdecoster merged 4 commits into
plotly:mainfrom
hirohira9119:disable_extensions

Conversation

@hirohira9119

@hirohira9119 hirohira9119 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Closes #302

This PR implements the enable_extensions option issued in #302 to allow disabling browser extensions.

Changes

  • Added support for enable_extensions: bool (True by default) argument.
  • Added associated tests.

@hirohira9119

hirohira9119 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Hi @camdecoster,

Just wanted to check if you've had a chance to look at this PR.
I'd appreciate it if you could review it when you have some time. Thank you!

@camdecoster camdecoster self-assigned this Jul 22, 2026
@camdecoster

camdecoster commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR! I'll take a look and follow up.

camdecoster
camdecoster requested changes Jul 22, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition! Could you please make the few suggested changes and add a CHANGELOG entry? With those items addressed, I can approve this PR.

Comment thread src/choreographer/browsers/chromium.py Outdated
Comment thread src/choreographer/browsers/chromium.py Outdated
Comment thread tests/conftest.py
hirohira9119 and others added 2 commits July 23, 2026 06:06
@hirohira9119 @camdecoster
Apply suggestions from code review
4df5464 
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
@hirohira9119
Address review feedback and update CHANGELOG
5d5217c
@hirohira9119

hirohira9119 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the review!

I have applied the suggested changes and updated the CHANGELOG.md accordingly. This PR should be ready for another look when you have a moment.

camdecoster
camdecoster reviewed Jul 22, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make a couple of more clean up changes? I missed these before.

Comment thread src/choreographer/browsers/chromium.py Outdated
Comment thread src/choreographer/browsers/chromium.py Outdated
@camdecoster
Fix some more docstrings
0d733b3 
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
@camdecoster

camdecoster commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The changes were so small that I just took care of them. Thanks for your work!

@camdecoster
camdecoster merged commit 1a79b3e into plotly:main Jul 22, 2026
4 checks passed
@hirohira9119
hirohira9119 deleted the disable_extensions branch July 23, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes

Assignees

@camdecoster camdecoster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add enable_extensions option to control browser extension loading

2 participants

@hirohira9119 @camdecoster