Add proxy server configuration for Chromium#304
Open
ColumbusLabs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxy_serverbrowser option that forwards Chromium’s--proxy-serverflagCHOREO_PROXY_SERVERenvironment fallback for Plotly and Kaleido callers that construct Choreographer internallyCloses #301
Testing
pytest -v tests/test_chromium.py(6 passed)ruff check --ignore CPY001 src/choreographer/browsers/chromium.py tests/test_chromium.pyruff format --check src/choreographer/browsers/chromium.py tests/test_chromium.pypyrightmypy src/choreographer/browsers/chromium.py tests/test_chromium.pyuv buildThe full local
poe testbrowser suite cannot complete on this macOS 26 machine because the repository-pinned Chrome 142 build exits during startup withchrome_crashpad_handler: --database is required. The sametest_watchdog[headless]failure reproduces from an untouchedorigin/mainworktree; the focused proxy tests and all non-browser checks above pass.