Skip to content

Add proxy server configuration for Chromium#304

Open
ColumbusLabs wants to merge 1 commit into
plotly:mainfrom
ColumbusLabs:codex/chromium-proxy-server
Open

Add proxy server configuration for Chromium#304
ColumbusLabs wants to merge 1 commit into
plotly:mainfrom
ColumbusLabs:codex/chromium-proxy-server

Conversation

@ColumbusLabs

Copy link
Copy Markdown

Summary

  • add a proxy_server browser option that forwards Chromium’s --proxy-server flag
  • add a CHOREO_PROXY_SERVER environment fallback for Plotly and Kaleido callers that construct Choreographer internally
  • redact authenticated proxy URLs from constructor and CLI logs
  • document both configuration paths and add focused regression coverage

Closes #301

Testing

  • pytest -v tests/test_chromium.py (6 passed)
  • ruff check --ignore CPY001 src/choreographer/browsers/chromium.py tests/test_chromium.py
  • ruff format --check src/choreographer/browsers/chromium.py tests/test_chromium.py
  • pyright
  • mypy src/choreographer/browsers/chromium.py tests/test_chromium.py
  • uv build

The full local poe test browser suite cannot complete on this macOS 26 machine because the repository-pinned Chrome 142 build exits during startup with chrome_crashpad_handler: --database is required. The same test_watchdog[headless] failure reproduces from an untouched origin/main worktree; the focused proxy tests and all non-browser checks above pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fig.to_image stuck in process on UNIX (behind Proxy)

1 participant