Skip to content

Bump maplibre-gl v4.5.2#7094

Merged
archmoj merged 4 commits into
masterfrom
maplibre-gl-4.5.2
Aug 13, 2024
Merged

Bump maplibre-gl v4.5.2#7094
archmoj merged 4 commits into
masterfrom
maplibre-gl-4.5.2

Conversation

@archmoj

@archmoj archmoj commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

@birkskyum Please review the baseline changes.
Thank you!

cc: @plotly/plotly_js s

@birkskyum

Copy link
Copy Markdown
Contributor

I don't see a diff anywhere.

@archmoj

archmoj commented Aug 13, 2024

Copy link
Copy Markdown
Contributor Author

There is a slight change there if you use the swipe option.

Screenshot from 2024-08-13 10-36-53

Here is the location of the diff from image comparison test on CircleCI.
diff-map_layers

As well as for diff-map_predefined-styles2 we have:
diff-map_predefined-styles2

@archmoj

archmoj commented Aug 13, 2024

Copy link
Copy Markdown
Contributor Author

@birkskyum This might be fine.
Just wanted to double check with you if this is alarming in respect to some changes between maplibre-gl versions.

@birkskyum

birkskyum commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

Hmm, It could be that either the previous or new version didn't manage to load the expected zoom level and used a blurred quarter of a tile from the zoom level above, if it didn't have time enough.

@archmoj

archmoj commented Aug 13, 2024

Copy link
Copy Markdown
Contributor Author

@birkskyum I'll move forward and merge this PR.
Please feel free to open a PR in case needed.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants