Add ability to use custom URL in cloud upload dialog#7896
Conversation
|
The styling for the "Share with Dash Enterprise" button isn't rendering correctly for me in this Codepen. Not sure if it's an issue with the build or the Codepen environment, but the other buttons render correctly. 
|
|
It does look (mostly) correct for me running fully local, so probably either an issue related to Codepen CSS, or with loading the bundle over internet. (Although the left button isn't flush left as it should be). 
|
|
Just discussed with Robert and I'm going to split the new default values for |
…custom-server-url
|
Let's add some language in this dialog to contact us if you're interested in this. |
| customBtn.on('click', function() { | ||
| customBtn.style('display', 'none'); | ||
| urlField.style('display', ''); | ||
| description.text(_(gd, 'If your Dash Enterprise instance supports chart sharing, you can enter its URL below. This chart and its data will be sent to the URL you provide.')); |
There was a problem hiding this comment.
"Enter the url of your Dash Enterprise chart server below or contact Plotly support to get set up. This chart and its data will be sent to the URL you provide."
There was a problem hiding this comment.
@emilykl Are you good with this wording?
| urlField.append('label') | ||
| .classed('plotly-cloud-dialog-label', true) | ||
| .attr('for', 'plotly-cloud-dialog-url') | ||
| .text(_(gd, 'Dash Enterprise URL')); |
There was a problem hiding this comment.
@emilykl Are you good with this wording?
| width: 640, | ||
| height: 640, | ||
| path: 'M176 544C96.5 544 32 479.5 32 400C32 336.6 73 282.8 129.9 263.5C128.6 255.8 128 248 128 240C128 160.5 192.5 96 272 96C327.4 96 375.5 127.3 399.6 173.1C413.8 164.8 430.4 160 448 160C501 160 544 203 544 256C544 271.7 540.2 286.6 533.5 299.7C577.5 320 608 364.4 608 416C608 486.7 550.7 544 480 544L176 544zM337 255C327.6 245.6 312.4 245.6 303.1 255L231.1 327C221.7 336.4 221.7 351.6 231.1 360.9C240.5 370.2 255.7 370.3 265 360.9L296 329.9L296 432C296 445.3 306.7 456 320 456C333.3 456 344 445.3 344 432L344 329.9L375 360.9C384.4 370.3 399.6 370.3 408.9 360.9C418.2 351.5 418.3 336.3 408.9 327L336.9 255z', | ||
| path: 'M451.5 160C434.9 160 418.8 164.5 404.7 172.7C388.9 156.7 370.5 143.3 350.2 133.2C378.4 109.2 414.3 96 451.5 96C537.9 96 608 166 608 252.5C608 294 591.5 333.8 562.2 363.1L491.1 434.2C461.8 463.5 422 480 380.5 480C294.1 480 224 410 224 323.5C224 322 224 320.5 224.1 319C224.6 301.3 239.3 287.4 257 287.9C274.7 288.4 288.6 303.1 288.1 320.8C288.1 321.7 288.1 322.6 288.1 323.4C288.1 374.5 329.5 415.9 380.6 415.9C405.1 415.9 428.6 406.2 446 388.8L517.1 317.7C534.4 300.4 544.2 276.8 544.2 252.3C544.2 201.2 502.8 159.8 451.7 159.8zM307.2 237.3C305.3 236.5 303.4 235.4 301.7 234.2C289.1 227.7 274.7 224 259.6 224C235.1 224 211.6 233.7 194.2 251.1L123.1 322.2C105.8 339.5 96 363.1 96 387.6C96 438.7 137.4 480.1 188.5 480.1C205 480.1 221.1 475.7 235.2 467.5C251 483.5 269.4 496.9 289.8 507C261.6 530.9 225.8 544.2 188.5 544.2C102.1 544.2 32 474.2 32 387.7C32 346.2 48.5 306.4 77.8 277.1L148.9 206C178.2 176.7 218 160.2 259.5 160.2C346.1 160.2 416 230.8 416 317.1C416 318.4 416 319.7 416 321C415.6 338.7 400.9 352.6 383.2 352.2C365.5 351.8 351.6 337.1 352 319.4C352 318.6 352 317.9 352 317.1C352 283.4 334 253.8 307.2 237.5z', |
There was a problem hiding this comment.
@emilykl I updated the icon here! I used the one you referenced
There was a problem hiding this comment.
(See the updated icon in the third photo in the description)
4535404 to
3aaf531
Compare
|
@emilykl This should be ready for another review! |
3 participants
Updates the dialog wording and adds a new button to allow for using a different URL for upload from the dialog:
