fix: handle 3-digit shorthand hex in hex_to_rgb#5662
Open
genrichez wants to merge 1 commit into
Open
Conversation
Expand 3-char hex codes (e.g. #FFF) to 6-char before parsing. Fixes both _plotly_utils and matplotlylib copies. Closes plotly#5661
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5661.
hex_to_rgbassumed the input was always 6 digits. 3-digit shorthand like#FFFwas parsed as(15, 15, 15 )instead of(255, 255, 255).Fix: expand 3-char codes to 6-char before slicing (e.g.
F→FF). Applied to both copies in_plotly_utils/colorsandplotly/matplotlylib/mpltools.Added tests for the shorthand case.