Move new menu item to sub menu

[krafit]

I went for the path of least resistance and I'm not sure, this is my preferred solution.

The alternative route would be one merged page. And registering a single slug and switch views via a ?view= parameter inside show_view(). That would have been tidier, but it touches every internal page=... link in the three views and the #statify_dashboard selectors in dashboard.js.
I wanted to keep the edits light instead of doing a big restructuring of the codebase, but if we decide to go for the more complete approach, I'm game.

[stklcode]

I like it. Though with same thoughs on the actual implementation.

Hidden menu pages are a pretty nice trick, but I think I'd prefer the "view" parameter here.

That would have been tidier, but it touches every internal page=... link in the three views [...]

Yes, but it's not that many links. Maybe bundle the generation to a helper method like dashboard_link( string $view ) if it gets too messy 🤔 But we have to take care about (hidden) form parameters, too.

[...] and the #statify_dashboard selectors in dashboard.js.

Really? We don't touch the DOM IDs within our views, so I guess there's no change required on this side.

#statify_dashboard is a selector for the dashboard widget anyway.

Sorry for taking over your branch, I've added a view=... refactoring als PoC, feel free to revert/drop the commit if we decide for another path.

[krafit]

The more the merrier! The view approach would have been more or less the other way I contemplated, so no hard feelings at all.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud