ADAPT-1794: Replace cutoff-dates with enum based additional validations on new topics#883
Open
aman-minz wants to merge 7 commits intopluralsight:masterfrom
Open
ADAPT-1794: Replace cutoff-dates with enum based additional validations on new topics#883aman-minz wants to merge 7 commits intopluralsight:masterfrom
aman-minz wants to merge 7 commits intopluralsight:masterfrom
Conversation
feat(pdp-870): update readme and create new dockerfile and makefile.
Minor change to test a new deployment functionality
fix(pdp-889): fix dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix default loophole and timestamp-mills validations on new topics we had introduced cutoff-date. This PR gets rid of those in favour of enum based additional validations stored in metadata.