Small usability improvements regarding instantiating a UriMaker.#14
Open
anaximander23 wants to merge 7 commits intopmhsfelix:masterfrom
Open
Small usability improvements regarding instantiating a UriMaker.#14anaximander23 wants to merge 7 commits intopmhsfelix:masterfrom
anaximander23 wants to merge 7 commits intopmhsfelix:masterfrom
Conversation
added 7 commits
September 14, 2015 16:04
…ks well from a base controller class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change here is to make
UriMaker<T>inherit fromUriMaker. This is mostly a "principle of least surprise" thing; in a lot of places the generic version is just calling through to the non-generic one, so it's clear that it is an extension and not a separate object. It also allows consuming code to specify a property of typeUriMakerin a base controller class, and assign the generic version to it.Following on, the second change is to add an alternate form of the
TryGetUriMakerFor<T>()method that can be used from outside the controller class. This allows a base class to havethis.TryGetUriMaker(Request);and when called from a derived class, aUriMaker<T>of the correct type is returned.