[feat] : added darkmode#42
Open
onlybond wants to merge 3 commits intopmndrs:mainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Open
Member
|
Hey! Your screenshots look great but when I open the website it opens like this:
Have you had this issue? It may be a linux thing |
Author
sure lemme see through it edit: maybe its a issue with how i am implementing the dark mode and have not optimized it for all devices. |
Author
|
@SaraVieira can you review it now |
Author
|
hey there @SaraVieira its been a long time. this is just a small pr, can you recheck the changes i have done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This PR addresses issue #9 by introducing dark mode across the entire application, providing users with a more comfortable viewing experience in low-light environments.
Challenges Faced: During implementation, I encountered challenges with theme customization. The application relies on pre-built themes, which limited direct color adjustments. To ensure consistency, I matched the dark mode colors with the existing theme used by the Leva component.
Status: Dark mode is now fully implemented and integrated across the application. Please review and provide feedback.