Revamp Trait Description Generation System for Easier Maintenance#1554
Open
g4nd41ph wants to merge 1 commit intopmotschmann:masterfrom
Open
Revamp Trait Description Generation System for Easier Maintenance#1554g4nd41ph wants to merge 1 commit intopmotschmann:masterfrom
g4nd41ph wants to merge 1 commit intopmotschmann:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactor of handling for exceptions to trait values in descriptions are handled. Moved them into a new optional desc_function() in each trait that takes a set of the values that are to be displayed and modifies them as required before returning the values.
Regression testing was performed and looks good as far as I can tell.
Also fixes incorrect values displayed in descriptions for Blurry, Chameleon, and Elusive:
Blurry previously said that surveyor death chance is reduced by X, which is incorrect, as X was the divisor modifier, and not the change in surveyor death chance. Used new desc_function setup to show that the change in surveyor death rates is actually X/(1+X).
Chameleon and Elusive both have the same incorrect description: their descriptions state that ambushes are X% less likely, but actually, the ambush chance divisor is increased by X%. This leads to nonsense like ambushes still happening when they are displayed as 100% less likely at rank 3 in both traits. Used the new desc_function setup to show that the change in ambush chance is (1 - (30 / (X + 30))).