Skip to content

fix: replace unsafe any types in kalshi normalizer #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realfishsam merged 1 commit into from
May 24, 2026
Merged

fix: replace unsafe any types in kalshi normalizer #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/exchanges/kalshi/fetcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export interface KalshiRawMarket {
volume_24h?: number;
volume?: number;
liquidity?: number;
liquidity_dollars?: string;
open_interest?: number;
volume_24h_fp?: string;
volume_fp?: string;
Expand Down
32 changes: 17 additions & 15 deletions core/src/exchanges/kalshi/normalizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,20 +121,22 @@ export class KalshiNormalizer implements IExchangeNormalizer<KalshiRawEvent, Kal
}

normalizeOHLCV(rawCandles: KalshiRawCandlestick[], params: OHLCVParams): PriceCandle[] {
type OhlcField = 'open' | 'high' | 'low' | 'close';

const candles = rawCandles.map((c) => {
const p = c.price || {};
const ask = c.yes_ask || {};
const bid = c.yes_bid || {};

const getVal = (field: string) => {
const pf = (p as any)[field];
const af = (ask as any)[field];
const bf = (bid as any)[field];
if (pf !== null && pf !== undefined) return pf;
if (af !== null && af !== undefined && bf !== null && bf !== undefined) {
const getVal = (field: OhlcField): number => {
const pf = p[field];
const af = ask[field];
const bf = bid[field];
if (pf != null) return pf;
if (af != null && bf != null) {
return (af + bf) / 2;
}
return (p as any).previous || 0;
return p.previous || 0;
};

return {
Expand Down Expand Up @@ -286,7 +288,7 @@ export class KalshiNormalizer implements IExchangeNormalizer<KalshiRawEvent, Kal
}
}

private deriveEventDescription(markets: any[]): string {
private deriveEventDescription(markets: KalshiRawMarket[]): string {
const texts = markets
.map((m) => m.rules_primary)
.filter((t): t is string => typeof t === 'string' && t.length > 0);
Expand Down Expand Up @@ -356,22 +358,22 @@ export class KalshiNormalizer implements IExchangeNormalizer<KalshiRawEvent, Kal

// -- Event sorting utility (exported for fetchEvents) -------------------------

function eventVolume(event: any): number {
return (event.markets || []).reduce((sum: number, m: any) => sum + (parseFloat(m.volume_fp ?? '') || Number(m.volume || 0)), 0);
function eventVolume(event: KalshiRawEvent): number {
return (event.markets || []).reduce((sum: number, m: KalshiRawMarket) => sum + (parseFloat(m.volume_fp ?? '') || Number(m.volume || 0)), 0);
}

function eventLiquidity(event: any): number {
return (event.markets || []).reduce((sum: number, m: any) => sum + (parseFloat(m.open_interest_fp ?? '') || parseFloat(m.liquidity_dollars || m.open_interest || m.liquidity || '0') || 0), 0);
function eventLiquidity(event: KalshiRawEvent): number {
return (event.markets || []).reduce((sum: number, m: KalshiRawMarket) => sum + (parseFloat(m.open_interest_fp ?? '') || parseFloat(String(m.liquidity_dollars || m.open_interest || m.liquidity || '0')) || 0), 0);
}

function eventNewest(event: any): number {
function eventNewest(event: KalshiRawEvent): number {
const times = (event.markets || [])
.map((m: any) => (m.close_time ? new Date(m.close_time).getTime() : 0))
.map((m: KalshiRawMarket) => (m.close_time ? new Date(m.close_time).getTime() : 0))
.filter((t: number) => t > 0);
return times.length > 0 ? Math.min(...times) : 0;
}

export function sortRawEvents(events: any[], sort: string): any[] {
export function sortRawEvents(events: KalshiRawEvent[], sort: string): KalshiRawEvent[] {
const copy = [...events];
if (sort === 'newest') {
copy.sort((a, b) => eventNewest(b) - eventNewest(a));
Expand Down
Loading