Skip to content

fix: Python UserTrade fields + PaginatedResult.total optional #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realfishsam merged 1 commit into from
May 24, 2026
Merged

fix: Python UserTrade fields + PaginatedResult.total optional #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions sdks/python/pmxt/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,12 @@ class UserTrade(Trade):
order_id: Optional[str] = None
"""The order that generated this fill"""

outcome_id: Optional[str] = None
"""The outcome this trade belongs to"""

market_id: Optional[str] = None
"""The market this trade belongs to"""


@dataclass
class PaginatedMarketsResult:
Expand All @@ -341,7 +347,7 @@ class PaginatedMarketsResult:
data: "List[UnifiedMarket]"
"""Markets in this page"""

total: int
total: Optional[int] = None
"""Total number of markets in the snapshot"""

next_cursor: Optional[str] = None
Expand All @@ -355,7 +361,7 @@ class PaginatedEventsResult:
data: "List[UnifiedEvent]"
"""Events in this page"""

total: int
total: Optional[int] = None
"""Total number of events in the snapshot"""

next_cursor: Optional[str] = None
Expand Down
Loading