- remove the requirement for temperature for claude models#140
Conversation
weilixu
commented
Jun 12, 2026
weilixu
commented
- yaml specs accept env parameter.
- optimize openstudio_ai context (input token cut ~50%)
- remove stop criteria for claude models
- yaml specs accept env parameter. - optimize openstudio_ai context (input token cut ~50%) - remove stop criteria for claude models
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bd52215f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| return os.environ[env_name] | ||
|
|
||
| return _ENV_PLACEHOLDER_RE.sub(replace, value) |
There was a problem hiding this comment.
Because this resolver is applied to the entire YAML document before validation, it also substitutes placeholders in user-facing fields such as instructions.text and agent_card descriptions/examples. A spec that includes a literal ${OPENAI_API_KEY} in prompt text or a card example will now either fail when unset or, worse, embed the secret value into the prompt/card when set, which can corrupt behavior or expose secrets through the served A2A card. Restrict substitution to intended config/secret fields or add an escape mechanism for literal placeholders.
Useful? React with 👍 / 👎.
1 participant
