Skip to content
This repository was archived by the owner on Apr 6, 2026. It is now read-only.

Upgrade to Spack v1.1.1 and related fixes.#196

Merged
pelesh merged 46 commits into
developfrom
nicholson/spack-v1.1
Feb 5, 2026
Merged

Upgrade to Spack v1.1.1 and related fixes.#196
pelesh merged 46 commits into
developfrom
nicholson/spack-v1.1

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Jan 29, 2026 •
edited by ovasios
Loading

Copy link
Copy Markdown
Collaborator

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

This upgrades the Spack submodule to v1.1.1 and deprecates incompatible build configurations (deception, newell and incline) that are not being tested with the new configuration.

  • With the Spack upgrade, now pointing to upstream Spack and using local Spack repos for modified packages that have yet to be contributed upstream. I plan to submit appropriate PRs to spack-packages once we know this works.
  • Updated Frontier modules accordingly. romcc is no longer a supported compiler, and mixes compiler modules are deprecated on Frontier. The only way to get a performant Fortran compiler for coinhsl, etc., and support HIP is to load PrgEnv-gnu and rocm. So, most packages are built built withgcc unless there is HIP code.
  • Moved deprecated configurations to deprecated folders with corresponding README files.

Linked Issue(s)

@nkoukpaizan nkoukpaizan self-assigned this Jan 29, 2026
@nkoukpaizan nkoukpaizan added enhancement New feature or request spack-build labels Jan 29, 2026
@pelesh

pelesh commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

CC @cameronrutherford

@nkoukpaizan

nkoukpaizan commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator Author

@cameronrutherford Do you know a fix for the error I'm seeing?

Error: invalid push configuration for mirror local-buildcache: environment variable `***` (secret_variable) not set

Everything is building fine, but the push to the container registry is not working.

@nkoukpaizan nkoukpaizan force-pushed the nicholson/spack-v1.1 branch 2 times, most recently from ea3b5fd to 021f9dd Compare January 30, 2026 19:55
@nkoukpaizan

nkoukpaizan commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator Author

@cameronrutherford Do you know a fix for the error I'm seeing?

Error: invalid push configuration for mirror local-buildcache: environment variable `***` (secret_variable) not set

Everything is building fine, but the push to the container registry is not working.

Finally figured out a way to make it work!

@nkoukpaizan nkoukpaizan marked this pull request as ready for review January 30, 2026 21:25
cameronrutherford
cameronrutherford suggested changes Jan 31, 2026
View reviewed changes

@cameronrutherford cameronrutherford left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some NITs, some other more interesting comments.

Comment thread .github/workflows/spack_cpu_build.yaml
Comment thread buildsystem/clang-hip/frontier/base.sh Outdated
Comment thread buildsystem/spack/load_spack.sh Outdated
Comment thread buildsystem/spack/spack_repo/exago/packages/exago/__pycache__/package.cpython-311.pyc Outdated
Comment thread buildsystem/spack/spack_repo/exago/packages/coinhsl/package.py
Comment thread buildsystem/spack/spack_repo/exago/packages/hiop/package.py
Comment thread buildsystem/spack/spack_repo/exago/packages/hiop/__pycache__/package.cpython-311.pyc Outdated
Comment thread CMakeLists.txt
Comment thread buildsystem/spack/spack_repo/exago/packages/exago/package.py
Comment thread buildsystem/spack/spack_repo/exago/packages/exago/package.py
@nkoukpaizan nkoukpaizan mentioned this pull request Feb 1, 2026
Closed
3 tasks
@cameronrutherford

cameronrutherford commented Feb 1, 2026

Copy link
Copy Markdown
Collaborator

LGTM if CI passes. I'm sure you'll get a better review from a maintainer about the package.py recipe anyway.

pelesh
pelesh reviewed Feb 1, 2026
View reviewed changes
Comment thread buildsystem/spack/spack_repo/exago/packages/hiop/package.py Outdated
nkoukpaizan and others added 19 commits February 2, 2026 21:34
@nkoukpaizan
Guard FUNCTIONALITY_TEST_SOPFLOW_SCENARIO_*_GPU with EXAGO_ENABLE_GPU.
06ce55b
@nkoukpaizan
Fix model/dependency combination for objective unit test.
5ef69ea
@nkoukpaizan
Use TESTING_MAX_NUMPROCS in run_test_logger.
b178ed1
@nkoukpaizan
Fix solver/model/dependency combination for objective unit test.
0742a25
@nkoukpaizan
Verbose spack install package in GH-Actions.
236b844
@nkoukpaizan
Print message with TESTING_MAX_NUMPROCS.
a65c116
@nkoukpaizan
Fix FUNCTIONALITY_TEST_SOPFLOW_SCENARIO3 dependencies.
3ca187d
@nkoukpaizan
Use exago_add_test built-in utility to fix dependency requirements.
73d5072
@nkoukpaizan
Fix EXAGO_ENABLE_HIOP_SPARSE definition scope.
651b5f9
@nkoukpaizan
mumps+mpi in GH-Actions.
924c861
@nkoukpaizan
Fix EXAGO_ENABLE_HIOP_SPARSE definition scope.
71e4c66
@nkoukpaizan
Set default TESTING_MAX_NUMPROCS back to 3.
22f38ca
@nkoukpaizan
Use the same PETSc configuration in GH-Actions as Frontier.
08b79b7
@nkoukpaizan @actions-user
Apply pre-commmit fixes
68c8888
@nkoukpaizan
Simplify initialization of EXAGO_ENABLE_HIOP_SPARSE.
c434c78
@nkoukpaizan
Remove --verbose from spack install in GH-Actions.
c59fcf3
@nkoukpaizan
CMAKE_SOURCE_DIR/build --> CMAKE_BINARY_DIR in CTEST_CUSTOM_PRE_TEST …
50310b8 
…and CTEST_CUSTOM_POST_TEST.
@nkoukpaizan
build_type=Debug to get more information on the remaining failing GH-…
74f5d27 
…Actions tests.
@nkoukpaizan
Revert "build_type=Debug to get more information on the remaining fai…
4f3400c 
…ling GH-Actions tests."

This reverts commit 74f5d27.
@nkoukpaizan nkoukpaizan marked this pull request as draft February 5, 2026 00:05
@nkoukpaizan

nkoukpaizan commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

I fixed several issues related to running the tests in GH-Actions (e.g., detecting the maximum number of available cores for testing in parallel, fixing test dependencies in CMake when some EXAGO_ENABLE_* options are off). Now, we can also build against ipopt~coinhsl+mumps ^mumps+mpi.

I documented the main remaining issues in #201. I suggest we keep the Test build stage of GH-Actions commented out for now.

@nkoukpaizan nkoukpaizan marked this pull request as ready for review February 5, 2026 01:25
@pelesh pelesh self-requested a review February 5, 2026 21:20
@pelesh pelesh merged commit 6f04993 into develop Feb 5, 2026
8 checks passed
@pelesh pelesh mentioned this pull request Feb 12, 2026
Closed
13 tasks
@nkoukpaizan nkoukpaizan deleted the nicholson/spack-v1.1 branch March 4, 2026 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abhyshr abhyshr Awaiting requested review from abhyshr

@cameronrutherford cameronrutherford Awaiting requested review from cameronrutherford

1 more reviewer

@pelesh pelesh pelesh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nkoukpaizan nkoukpaizan

Labels

enhancement New feature or request spack-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nkoukpaizan @pelesh @cameronrutherford