Fixes to CMake configuration to enable testing from build directory#200
Conversation
|
I am currently getting a few new test failures on Frontier, I think because not every instance of Otherwise, the approach works for the updated cases and supports A few additional thoughts:
I would suggest explicitly defining the testing data directory (similar to |
This was my doing from several years ago. I agree, that needs to be removed. |
I am not sure about the need to install tests. Perhaps if one has binary only installation of ExaGO, one might want to have an ability to verify that installation does what it is supposed to do. |
PhilipFackler
left a comment
There was a problem hiding this comment.
This looks good to me.
- Create entry for user to add PETSC_DIR - EXAGO_ENABLE_GPU set automatically to "on" if either CUDA or HIP backends are enabled. - Fixes in testing CMake configuration to be able to run tests from build directory.
|
@nkoukpaizan, I set the data files directory in the source as the one to be used for testing. I also removed copying data to the build directory. I left installation of tests in there for now. |
2daedb3 to
9511d56
Compare
nkoukpaizan
left a comment
There was a problem hiding this comment.
This addresses the issue of needing make test install before make test. Will need another cleanup pass (e.g., disallowing testing from the installation directory if the build directory is not available).
Merge request type
Relates to
This MR updates
Summary
I made some changes to CMake, mainly to enable running tests without installing ExaGO first. This is still work in progress but some feedback would be helpful to figure out how to proceed.
Closes #148.
Closes #58.