Skip to content

RDS New Rule Section 6 - 2019 & 2022 #1800

Merged
weilixu merged 4 commits into
developfrom
RDS/JDJ/6-12
Feb 25, 2026
Merged

RDS New Rule Section 6 - 2019 & 2022 #1800
weilixu merged 4 commits into
developfrom
RDS/JDJ/6-12

Conversation

@JacksonJ-KC

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread docs/ashrae9012022/section6/Rule6-12.md Outdated
Comment thread docs/ashrae9012022/section6/Rule6-12.md Outdated
@JacksonJ-KC JacksonJ-KC changed the base branch from feature/ashrae-9012022 to develop September 3, 2025 20:02
@JacksonJ-KC JacksonJ-KC changed the title RDS/JDJ/6-12 90.1-2022 RDS/JDJ/6-12 Sep 3, 2025
Comment thread docs/ashrae9012022/section6/Rule6-12.md Outdated
- Case 1: All interior lighting in the space is controlled by occupancy sensors and modeled via adjustments to the schedules: PASS `if not any(val in ["NONE", "MANUAL_ON", None] for val in occupancy_controls_b): PASS`
- Case 2: Any interior lighting in the space is missing definitions for occupancy sensor type and schedule adjustments: UNDETERMINED `elif any(val is None for val in occupancy_controls_b) or any(val is None for val in occupancy_sensor_schedules_b): UNDETERMINED`
- Case 3: Else, at least one interior lighting data group in the space is not controlled by occupancy sensors or modeled via adjustments to the schedules: FAIL `else: FAIL`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand the difference between case 2 and case 3. Looks like case 2 is checking for missing values and case 3 is checking for explicitly set 'No' values?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, a lot of times Case 2 is not written out explicitly and RCT dev team handles it

@supriyagoel supriyagoel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all cases look good.

@JacksonJ-KC JacksonJ-KC changed the title RDS/JDJ/6-12 RDS New Rule Section 6 - 2019 & 2022 Dec 24, 2025
@jugonzal07

Copy link
Copy Markdown
Contributor

I'm a bit stumped by the numbering on this rule. I'm seeing Section 6 Rule 12 but does that rule not already exist?

https://github.com/pnnl/ruleset-checking-tool/blob/develop/rct229/rulesets/ashrae9012022/section6/section6rule12.py

Is it possible we meant to renumber this to something else?

@JacksonJ-KC

Copy link
Copy Markdown
Collaborator Author

@jugonzal07 this RDS appears to match the rule description of rule 6-13 in the develop branch.

https://github.com/pnnl/ruleset-checking-tool/blob/develop/rct229/rulesets/ashrae9012019/section6/section6rule13.py
https://github.com/pnnl/ruleset-checking-tool/blob/develop/rct229/rulesets/ashrae9012022/section6/section6rule13.py

@weilixu weilixu merged commit 15cbedd into develop Feb 25, 2026
2 checks passed
@weilixu weilixu deleted the RDS/JDJ/6-12 branch February 25, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants