Guard against undefined verificationUri and userCode in device code flow#7172
Draft
eschoeller wants to merge 3 commits intopnp:mainfrom
Draft
Guard against undefined verificationUri and userCode in device code flow#7172eschoeller wants to merge 3 commits intopnp:mainfrom
eschoeller wants to merge 3 commits intopnp:mainfrom
Conversation
Member
|
@eschoeller thanks for openning the PR but lets keep it draft for now since I cannot seem to be able to reporduce the bug you described |
Author
|
Oh sure, that's a good idea. Should have I sent it as a draft initially? I haven't been able to actually use the CLI much yet - waiting on my org to enable a few more things .. but I did encounter this issue. I'd be happy to test it again, perhaps it's been fixed somehow now. It was well over a week ago when I stumbled into it the first time at this point. I have a few more fixes/features queued up too. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.verificationUribefore callingbrowserUtil.open()inprocessDeviceCodeCallbackresponse.userCodebefore callingclipboardy.writeSync()Both crash with
TypeErrorwhen the MSALDeviceCodeResponsedoes not populate these fields andautoOpenLinksInBrowserorcopyDeviceCodeToClipboardare enabled.Closes #7167