Migrates context commands to Zod. Closes #7293#7363
Open
waldekmastykarz wants to merge 1 commit into
Open
Conversation
Migrates context-init and option-set commands from the old #initOptions() pattern to Zod schemas, completing the migration of all context commands. Changes: - context-init: Add Zod schema with global options - option-set: Replace #initOptions() constructor with Zod schema defining name and value as required string options with aliases - Update test files to import and use commandOptionsSchema.parse() - Add schema validation tests for both commands Closes pnp#7293 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7293
Completes the Zod migration for the two remaining
contextcommands that still used the old#initOptions()pattern:context-init: Added a Zod schema with global options and theget schema()getter. This command has no custom options, so the schema only spreadsglobalOptionsZod.option-set: Replaced the constructor-based#initOptions()andGlobalOptionsinterface with a ZodstrictObjectschema definingname(aliasn) andvalue(aliasv) as required strings.Updated both test files to import the exported
optionsschema, set upcommandOptionsSchemaviagetSchemaToParse(), usecommandOptionsSchema.parse()in allcommand.action()calls, and added schema validation tests (required fields, unknown options).The other three context commands (
context-remove,option-list,option-remove) were already migrated.