Migrate entra administrativeunit member and roleassignment commands to Zod#7364
Open
waldekmastykarz wants to merge 1 commit into
Open
Migrate entra administrativeunit member and roleassignment commands to Zod#7364waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
…o Zod Migrate the following commands from manual option validation to Zod schemas: - entra administrativeunit member add - entra administrativeunit member get - entra administrativeunit member list - entra administrativeunit member remove - entra administrativeunit roleassignment add Closes pnp#7294 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the following commands from manual option validation to Zod schemas:
entra administrativeunit member addentra administrativeunit member getentra administrativeunit member listentra administrativeunit member removeentra administrativeunit roleassignment addCloses #7294
Changes
Replaced manual
#initOptions(),#initValidators(),#initOptionSets(), and#initTelemetry()methods with declarative Zod schemas usingz.strictObject(),z.uuid(),.alias(), andgetRefinedSchema()with.refine()for option set validation.Updated all corresponding test files to use
commandOptionsSchema.safeParse()for schema and option set validation tests.Net reduction of ~669 lines of code.