Migrate entra approleassignment and enterpriseapp commands to Zod#7365
Open
waldekmastykarz wants to merge 1 commit into
Open
Migrate entra approleassignment and enterpriseapp commands to Zod#7365waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
Migrates the following commands from legacy options/validators to Zod schemas: - entra approleassignment add - entra approleassignment list - entra approleassignment remove - entra enterpriseapp add - entra enterpriseapp get - entra enterpriseapp list - entra enterpriseapp remove Closes pnp#7295 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the following commands from legacy options/validators to Zod schemas:
entra approleassignment addentra approleassignment listentra approleassignment removeentra enterpriseapp addentra enterpriseapp getentra enterpriseapp listentra enterpriseapp removeChanges per command
interface Options extends GlobalOptionswithexport const options = z.strictObject({...globalOptionsZod.shape, ...})validation.isValidGuid()) withz.uuid()#initOptions(),#initValidators(),#initOptionSets(),#initTelemetry(),#initTypes()with declarative Zod schema +getRefinedSchema()for option setsget schema()methodTest changes
commandOptionsSchema.safeParse()instead ofcommand.validate()asyncfor validation)Closes #7295