Migrate entra groupsetting and groupsettingtemplate commands to Zod#7366
Open
waldekmastykarz wants to merge 1 commit into
Open
Migrate entra groupsetting and groupsettingtemplate commands to Zod#7366waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
Migrate all 7 commands to use Zod schemas for option validation: - entra groupsetting add - entra groupsetting get - entra groupsetting list - entra groupsetting remove - entra groupsetting set - entra groupsettingtemplate get - entra groupsettingtemplate list Closes pnp#7297 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all 7
entra groupsettingandentra groupsettingtemplatecommands to use Zod schemas for option validation, replacing the legacy#initOptions(),#initValidators(),#initTelemetry(), and#initOptionSets()patterns.Closes #7297
Commands migrated
entra groupsetting addlooseObjectentra groupsetting getstrictObjectentra groupsetting liststrictObjectentra groupsetting removestrictObjectentra groupsetting setlooseObjectentra groupsettingtemplate getstrictObjectgetRefinedSchemaentra groupsettingtemplate liststrictObjectChanges per command
interface Options extends GlobalOptionswith Zod schema definitionsz.uuid().alias()for short option namesget schema()gettergetRefinedSchema()for option set validation (groupsettingtemplate get)#initOptions(),#initValidators(),#initTelemetry(),#initOptionSets()Test changes
command.validate()tocommandOptionsSchema.safeParse()supports specifyingtests that checkedcommand.optionsarraysettingsNamesstubs no longer needed for option set validation