Migrate entra multitenant and oauth2grant commands to Zod#7367
Open
waldekmastykarz wants to merge 1 commit into
Open
Migrate entra multitenant and oauth2grant commands to Zod#7367waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
Migrated the following commands from legacy options/validators/telemetry to Zod schema-based validation: - entra multitenant get - entra multitenant remove - entra multitenant set - entra oauth2grant add - entra oauth2grant list - entra oauth2grant remove - entra oauth2grant set Updated corresponding test files to use Zod schema parsing. Closes pnp#7298 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Closes #7298
Migrates the following commands from legacy options/validators/telemetry to Zod schema-based validation:
entra multitenant getentra multitenant removeentra multitenant setentra oauth2grant addentra oauth2grant listentra oauth2grant removeentra oauth2grant setChanges
#initOptions(),#initValidators(),#initTelemetry(), and#initTypes()with exported Zodoptionsschemasget schema()getter to each commandz.uuid()for GUID validation (clientId,resourceId,spObjectId)z.boolean().optional().alias('f')forforceoptionsgetRefinedSchemafor themultitenant setcommand's "at least one of displayName/description" validationcommandOptionsSchema.safeParse()/.parse()instead ofcommand.validate()How to test
All existing tests pass. Build succeeds.