Skip to content

Migrate entra multitenant and oauth2grant commands to Zod#7367

Open
waldekmastykarz wants to merge 1 commit into
pnp:mainfrom
waldekmastykarz:waldekmastykarz/migrate-entra-oauth2grant-zod
Open

Migrate entra multitenant and oauth2grant commands to Zod#7367
waldekmastykarz wants to merge 1 commit into
pnp:mainfrom
waldekmastykarz:waldekmastykarz/migrate-entra-oauth2grant-zod

Conversation

@waldekmastykarz
Copy link
Copy Markdown
Member

What's in this PR?

Closes #7298

Migrates the following commands from legacy options/validators/telemetry to Zod schema-based validation:

  • entra multitenant get
  • entra multitenant remove
  • entra multitenant set
  • entra oauth2grant add
  • entra oauth2grant list
  • entra oauth2grant remove
  • entra oauth2grant set

Changes

  • Replaced #initOptions(), #initValidators(), #initTelemetry(), and #initTypes() with exported Zod options schemas
  • Added get schema() getter to each command
  • Used z.uuid() for GUID validation (clientId, resourceId, spObjectId)
  • Used z.boolean().optional().alias('f') for force options
  • Used getRefinedSchema for the multitenant set command's "at least one of displayName/description" validation
  • Updated all test files to use commandOptionsSchema.safeParse() / .parse() instead of command.validate()
  • Removed legacy "supports specifying X" tests (now covered by schema)

How to test

All existing tests pass. Build succeeds.

Migrated the following commands from legacy options/validators/telemetry
to Zod schema-based validation:

- entra multitenant get
- entra multitenant remove
- entra multitenant set
- entra oauth2grant add
- entra oauth2grant list
- entra oauth2grant remove
- entra oauth2grant set

Updated corresponding test files to use Zod schema parsing.

Closes pnp#7298

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate entra multitenant and oauth2grant commands to Zod

1 participant