Migrate entra pim and policy commands to Zod#7368
Open
waldekmastykarz wants to merge 1 commit into
Open
Conversation
Migrates 6 commands from the old manual options/validators/optionSets pattern to the new Zod schema-based validation: - pim-role-assignment-add - pim-role-assignment-list - pim-role-assignment-remove - pim-role-assignment-eligibility-list - pim-role-request-list - policy-list For pim-role-assignment-add, the --no-expiration option is now handled via yargs boolean negation: expiration defaults to true, and --no-expiration sets it to false. Closes pnp#7299 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates 6
entra pimandentra policycommands from the old manual options/validators/optionSets pattern to the new Zod schema-based validation.Commands migrated
entra pim role assignment addentra pim role assignment listentra pim role assignment removeentra pim role assignment eligibility listentra pim role request listentra policy listNotable changes
pim-role-assignment-add, the--no-expirationoption is handled via yargs boolean negation:expirationdefaults totrue, and--no-expirationsets it tofalse.#initTelemetry(),#initOptions(),#initValidators(),#initOptionSets(), and#initTypes()methods in favor of Zod schemas.commandOptionsSchema.safeParse()instead ofcommand.validate().Closes #7299