Skip to content

Migrate external commands to Zod#7369

Open
waldekmastykarz wants to merge 1 commit into
pnp:mainfrom
waldekmastykarz:waldekmastykarz/migrate-external-to-zod
Open

Migrate external commands to Zod#7369
waldekmastykarz wants to merge 1 commit into
pnp:mainfrom
waldekmastykarz:waldekmastykarz/migrate-external-to-zod

Conversation

@waldekmastykarz
Copy link
Copy Markdown
Member

Summary

Migrates all external commands from the legacy options/validators/telemetry pattern to Zod schema validation.

Closes #7302

Changes

Migrated the following commands:

  • connection-add — ID validation (length, alphanumeric, reserved words) via .min()/.max()/.refine()
  • connection-get — Option set (id/name) via getRefinedSchema()
  • connection-remove — Option set (id/name) + force boolean via getRefinedSchema()
  • connection-doctorux enum validation via z.enum()
  • connection-schema-add — External connection ID + JSON schema content validation via .refine()
  • connection-urltoitemresolver-add — Simple required options migration
  • item-add — ACL validation via .refine(), uses z.object (not z.strictObject) for allowUnknownOptions support, switched to addUnknownOptionsToPayloadZod

connection-list was already migrated to Zod.

Testing

  • All 15724 tests pass
  • Lint passes
  • 100% coverage on all changed files

Migrates all external commands (connection-add, connection-get,
connection-remove, connection-doctor, connection-schema-add,
connection-urltoitemresolver-add, item-add) from the legacy
options/validators pattern to Zod schema validation.

Closes pnp#7302

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate external commands to Zod

1 participant