Migrate file commands to Zod#7370
Open
waldekmastykarz wants to merge 2 commits into
Open
Conversation
Migrates all 5 file commands under src/m365/file/commands/ from the old options/validators/telemetry pattern to Zod schemas: - file add - file copy - file list - file move - file convert pdf Closes pnp#7303 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds missing test to cover the folderUrl validation error callback, fixing 100% function coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all 5
filecommands to use Zod schemas for option definitions and validation, replacing the old#initTelemetry,#initOptions, and#initValidatorspattern.Commands migrated
file addfolderUrl/siteUrlSharePoint URL validation via Zod refine;filePathexistence check viagetRefinedSchemafile copywebUrlSharePoint URL validation;nameConflictBehaviorasz.enumfile listwebUrlSharePoint URL validation;recursiveas optional booleanfile movewebUrlSharePoint URL validation;nameConflictBehaviorasz.enumfile convert pdfsourceFile/targetFileexistence checks viagetRefinedSchemaChanges per file
#initTelemetry,#initOptions,#initValidators; added exportedz.strictObjectschema withglobalOptionsZod.shapespread andget schema()gettercommandOptionsSchema.safeParse()instead ofcommand.validate()Closes #7303