Migrate outlook message and mail commands to Zod#7374
Open
waldekmastykarz wants to merge 2 commits into
Open
Conversation
Migrates the following commands to use Zod validation schemas: - outlook message get - outlook message list - outlook message move - outlook message remove - outlook mail send Closes pnp#7308 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
@waldekmastykarz, seems like not all code is covered by tests. |
Add explicit tests for schema getters, refined schemas, and Zod error callbacks (invalid GUID/UPN) to reach 100% function coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR
Migrates the
outlook messageandoutlook mailcommands to use Zod validation schemas, replacing the legacy interface-based validation pattern.Commands migrated
outlook message getoutlook message listoutlook message moveoutlook message removeoutlook mail sendChanges per command
constructor,#initTelemetry(),#initOptions(),#initValidators(),#initTypes(),#initOptionSets()options) withz.strictObject()get schema()andgetRefinedSchema()methodscommandOptionsSchema.safeParse()for validation testsNotes
mail-send.tskeepsthis.validatorsfor filesystem-dependent attachment validation (file existence/size checks can't be expressed as Zod schemas)mail-searchfolder-add.tswas already migrated and is not part of this PRCloses #7308