Add favicon and implement markdown copy functionality with UI enhancements#5339
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a "Copy as Markdown" UI to documentation pages, replaces the favicon with a PnP-branded SVG, and updates the build script to publish raw Markdown source files alongside the rendered DocFX site so the new copy/view button can fetch them.
Changes:
- Introduces page-level Markdown copy + "View as Markdown" dropdown in the custom modern template (JS + CSS), wired in via the template's
start()hook. - Updates
Build-Site.ps1to copy root,articles/, andcmdlets/Markdown into_site/markdown/afterdocfx build, matching the client-side URL mapping. - Switches
_appFaviconPathto a new localimages/favicon-pnp.svgand adds manual validation steps to the build documentation.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pages/templates/pnp-modern/public/main.js | Adds Markdown URL resolver, clipboard helper, dropdown/button UI, and start() initialization. |
| pages/templates/pnp-modern/public/main.css | Adds styling for the copy Markdown button group, dropdown menu, and dark-mode variants. |
| pages/Build-Site.ps1 | Adds Copy-MarkdownFiles/Copy-MarkdownSourceFiles and invokes after DocFX build. |
| pages/docfx.json | Points _appFaviconPath to the new local SVG favicon. |
| pages/images/favicon-pnp.svg | New PnP-branded SVG favicon resource. |
| pages/articles/buildingdocumentation.md | Adds favicon and copy-Markdown items to manual validation checklist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Updated docs with copy markdown and favico and stuff