fix: raise the camera anchor so the head fits the frame - #1
Open
liuzl wants to merge 1 commit into
Open
Conversation
airi frames the full head with headroom (docs/airi-vrm-stage.png), but at anchor 0.72 the 40-degree cone at 1 m tops out below the crown — the hair top is clipped by the window edge, visible in the committed reference shots too. 0.78 keeps the whole head inside the frame on AvatarSample_A, matching airi's framing. Verify: target/release/pocket-character --headless-shot shot.png --ticks 90 (before: crown cut by the top edge; after: full head with headroom). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The widget clips the top of the character's hair at the window edge — visible in the repo's own reference shots (
docs/pocket-character-idle.png) as well as live. The parity reference (docs/airi-vrm-stage.png) frames the full head with headroom, so this is a framing divergence from the airi stage the README declares parity with.Geometry: the anchor sits at 0.72 of model height with a 40° vertical fov at 1 m — the cone tops out a few cm below the crown on AvatarSample_A.
Fix
Anchor 0.72 → 0.78: the whole head lands inside the frame with headroom, matching airi's framing. One constant, comment updated with the reasoning.
Verify
Before: crown cut by the top edge (same as the committed reference shots). After: full head visible with headroom, body coverage down to the hips retained.
🤖 Generated with Claude Code