Uncommented dataProviderSettings#11
Open
SOF3 wants to merge 1 commit into
Open
Conversation
ghost
mentioned this pull request
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why @shoghicp thought it'd be good to comment out the settings the user probably won't need and leave a placeholder value behind. Telling the player not to touch it if they don't use MySQL is much better than expecting users unfamiliar with YAML syntax to figure out the proper way to uncomment it. 10 out of 10 humans unfamiliar with YAML syntax will believe that they do not need to keep the space after deleting the #.