Merged
Conversation
new syntax: LValue ::= Variable | Deref modify assignment syntax: assignStmt ::= Type? LValue '=' Expr';'
✅ Deploy Preview for espl1000 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MDr164
approved these changes
Mar 3, 2025
Contributor
MDr164
left a comment
MDr164
left a comment
There was a problem hiding this comment.
I'm lacking quite a bit of understanding of the code base but I could not spot any obvious errors and the added code is coherent. Take the review with a grain of salt though and treat it more like a Gerrit +1 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new syntax:
LValue ::= Variable | Deref
modify assignment syntax:
assignStmt ::= Type? LValue '=' Expr';'
TODO: