Skip to content

[Utility] Add servicer module mock#960

Open
adshmh wants to merge 4 commits into
mainfrom
utiltiy-servicer-add-mock
Open

[Utility] Add servicer module mock#960
adshmh wants to merge 4 commits into
mainfrom
utiltiy-servicer-add-mock

Conversation

@adshmh

@adshmh adshmh commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Description

Adds mock generation for the servicer module to support testing.

Issue

Part of work on #860

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Moved servicer module mock generation to its own file.
  • Updated references to the servicer module name

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@adshmh adshmh added the utility Utility specific changes label Aug 2, 2023
@adshmh adshmh added this to the M3: Pocket RoS (Relay or Slash) milestone Aug 2, 2023
@adshmh adshmh self-assigned this Aug 2, 2023
@reviewpad reviewpad Bot added small Pull request is small waiting-for-review labels Aug 2, 2023
@adshmh adshmh requested review from dylanlott and h5law August 2, 2023 14:17

@Olshansk Olshansk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adshmh I know I wasn't added as a reviewer on this originally, but noticed it was a small PR that's been open for a few days, so I went ahead and took a look.

Comment thread shared/modules/utility_module.go Outdated
Comment thread shared/modules/servicer_module.go
@adshmh adshmh requested review from Olshansk and dylanlott August 9, 2023 18:54
@h5law h5law removed request for dylanlott and h5law December 10, 2023 20:38
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.83%. Comparing base (afc873e) to head (699f939).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
utility/module.go 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   34.83%   34.83%           
=======================================
  Files         128      128           
  Lines       10986    10986           
=======================================
  Hits         3827     3827           
  Misses       6667     6667           
  Partials      492      492           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Pull request is small utility Utility specific changes waiting-for-review

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants