Skip to content

Fix name collision of variable P and function P()#9

Open
mtmccrea wants to merge 2 commits into
polarch:masterfrom
mtmccrea:mtm
Open

Fix name collision of variable P and function P()#9
mtmccrea wants to merge 2 commits into
polarch:masterfrom
mtmccrea:mtm

Conversation

@mtmccrea
Copy link
Copy Markdown

@mtmccrea mtmccrea commented Oct 4, 2024

There was a name collision of variable P and function P(), this was fixed previously, but it left out the correction in the if clause for the case of complex SHs. To generalize the correction, all of the functions that generate the P, U, V, and W terms are called getP, getU, etc. Because these are local functions it won't impact backward compatibility.

There's also a typo fix and minor change to the function that plots spherical functions, which adjusts the edge alpha so it's less distracting, esp. for very dense designs.

@mtmccrea
Copy link
Copy Markdown
Author

mtmccrea commented Oct 4, 2024

After looking more closely (I had a diverging version history), this is a redundant change with Leo's previous fix of the same issue, but I still think the renaming of the functions is useful for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant