Skip to content

Return email in LoginByOAuthResponse when available from provider#15

Merged
slhmy merged 2 commits intomainfrom
copilot/add-email-to-login-oauth-response
Feb 8, 2026
Merged

Return email in LoginByOAuthResponse when available from provider#15
slhmy merged 2 commits intomainfrom
copilot/add-email-to-login-oauth-response

Conversation

Copy link
Contributor

Copilot AI commented Feb 8, 2026

OAuth providers may return email addresses, but this data was previously discarded in the login response despite being fetched internally.

Changes

  • Proto: Added email field (field 4) to LoginByOAuthResponse
  • Service: Populated Email: userInfo.Email in LoginByOAuth response
  • Generated code: Updated protobuf bindings and OpenAPI spec

The existing maybeFillOAuthEmail() logic already fetches email from providers when available or when configured to make additional API calls. This change exposes that data to clients.

message LoginByOAuthResponse {
  TokenPair token = 1;
  string username = 2;
  string avatar_url = 3;
  string email = 4;  // New field
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • buf.build
    • Triggering command: /home/REDACTED/go/bin/buf /home/REDACTED/go/bin/buf generate -goversion go1.24.12 -symabis /tmp/go-build1531633152/b758/symabis -c=4 -nolocalimports -importcfg /tmp/go-build1531633152/b758/importcfg -pack -asmhdr fetc�� me.go quency_frame.go (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: slhmy <31381093+slhmy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add email to LoginByOAuthResponse if available from provider Return email in LoginByOAuthResponse when available from provider Feb 8, 2026
Copilot AI requested a review from slhmy February 8, 2026 09:44
@slhmy slhmy marked this pull request as ready for review February 8, 2026 09:44
@slhmy slhmy merged commit 3fc2f09 into main Feb 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants