feat(sponsorblock): add "hook" category#272
Open
curbengh wants to merge 1 commit intopolymorphicshade:devfrom
Open
feat(sponsorblock): add "hook" category#272curbengh wants to merge 1 commit intopolymorphicshade:devfrom
curbengh wants to merge 1 commit intopolymorphicshade:devfrom
Conversation
Collaborator
|
Thank you for your PR. Could you please resolve problems in CI build 🙏🏻 |
Author
|
Added missing |
Collaborator
|
still failing. Could you please re-check for typos? |
Author
|
added missing |
Author
|
probably need to clear CI cache? |
Collaborator
I'm not sure, cache should not a problem. Could you please re-view logs: /home/runner/work/Tubular/Tubular/app/src/main/java/org/schabi/newpipe/player/Player.java:2625: error: an enum switch case label must be the unqualified name of an enumeration constant
case HOOK -> prefs.getString(
^
> Task :app:compileDebugJavaWithJavac
/home/runner/work/Tubular/Tubular/app/src/main/java/org/schabi/newpipe/util/ExtractorHelper.java:426: error: cannot find symbol
result.includeHookCategory =
^
symbol: variable includeHookCategory
location: variable result of type SponsorBlockApiSettings
/home/runner/work/Tubular/Tubular/app/src/main/java/org/schabi/newpipe/fragments/list/sponsorblock/SponsorBlockFragment.java:334: error: cannot find symbol
context, SponsorBlockCategory.HOOK),
^
symbol: variable HOOK
location: class SponsorBlockCategory
/home/runner/work/Tubular/Tubular/app/src/main/java/org/schabi/newpipe/util/SponsorBlockHelper.java:87: error: an enum switch case label must be the unqualified name of an enumeration constant
case HOOK -> {
^
/home/runner/work/Tubular/Tubular/app/src/main/java/org/schabi/newpipe/util/SponsorBlockHelper.java:166: error: an enum switch case label must be the unqualified name of an enumeration constant
case HOOK -> context.getString(
^
/home/runner/work/Tubular/Tubular/app/src/main/java/org/schabi/newpipe/util/SponsorBlockHelper.java:193: error: an enum switch case label must be the unqualified name of an enumeration constant
case HOOK -> context
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
6 errors
FAILURE: Build failed with an exception.
> Task :app:compileDebugJavaWithJavac FAILED
* What went wrong:
Execution failed for task ':app:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ajayyy/SponsorBlock@f4d2558