fix: improve URL blacklist support and prevent functionality bypass#817
Open
puppywang wants to merge 1 commit intopolywock:masterfrom
Open
fix: improve URL blacklist support and prevent functionality bypass#817puppywang wants to merge 1 commit intopolywock:masterfrom
puppywang wants to merge 1 commit intopolywock:masterfrom
Conversation
- Fix: disabled playback speed and effects on blacklisted URLs in ConfigSync.ts\n- Update: enhanced URL matching in configUtils.ts to support input without protocol prefixes\n- Improve: dynamic icon status updates on tab switch via badge.ts watchers\n- Refactor: cleaned up debug logs and unified site activity checks
Owner
Hello! At least for me, turning off Global Speed using the power icon or a URL rule set to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses an issue where the extension's functionality (playback speed and filters) remained active on blacklisted sites even when the icon correctly indicated an inactive state (turned gray). It also improves the URL matching user experience.
Key Changes:
urlModechecks inConfigSync.ts. Now, playback speed adjustments, effect synchronization, and the circle widget are completely disabled when the current URL is blacklisted.testURLWithPartutility to support domain-based matching without requiring explicit protocol prefixes (e.g., example.com correctly matches http://example.com).keybindsUrlConditioninto the background badge.ts watchers. The extension icon now updates its state immediately upon tab switching or rule modification.isActiveOnSitestate and removed obsolete debug logs.Verified on live.bilibili.com: the speed control no longer responds when the site is blacklisted, consistent with the gray icon state.
Any commet is welcomed.